Fixes page header when displaying Cloud Networks list #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit GregP@f55b1c5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label blocker |
|
@GregP if this can be backported, can you add the gaprindashvili/yes label. |
|
@h-kataria Ready for review. |
|
looks good |
simaishi
pushed a commit
that referenced
this pull request
Jul 11, 2018
Fixes page header when displaying Cloud Networks list (cherry picked from commit 5fa5cad) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1599353
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect action value passed when building page header text for Cloud Networks list view.
https://bugzilla.redhat.com/show_bug.cgi?id=1588326
Screen shot prior to code fix:
Screen shot post code fix:
