Fix asset pipeline for remote consoles when loading jquery #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@3997623 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, merging when green 👍 (tested with: ) (gaprindashvili/no because #3998 is g/no) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When precompiling assets, somehow sprockets goes crazy because of this line and skips everything after. This caused issues with remote consoles that are dependent on jQuery.
Closes #4251
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1597352
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1600139
@miq-bot add_label bug, gaprindashvili/no
@miq-bot assign @himdel