Set Status of Physical Servers and Physical Switches in Topology View

[caiocmpaes]

What this PR does:

• Set the status of the PhysicalServers and PhysicalSwitches nodes in the topology view to be relative to the entity's health_state.

As the picture shows, the nodes get borders in one of this colors:

• Gray: Unknown Health State status;
• Green: Valid Health State status;
• Yellow: Warning Health State status;
• Red: Critical Health State status;

[miq-bot]

Checked commit https://github.com/caiocmpaes/manageiq-ui-classic/commit/803be80d6c0446c5e3a514bb078280bb02851af1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

[caiocmpaes]

@miq-bot assign @skateman

@skateman Should I make a refactoring on my code at the physical_infra_topology_service.rb in order to avoid the issues of Codeclimate? Or I can let the code as It is?

[skateman]

@caiocmpaes I assume you will add other stuff to this topology, so let's do it after all the things are in.

[caiocmpaes]

Ok. This PR is only intended to add this border to the topology nodes. This is my only goal. When #4065 get merged, I will add PhysicalChassis nodes and relationships to the topology. Probably, this should be in a new PR, right?

[skateman]

Yup, so after all is in, we can refactor 😉

[mzazrivec]

@skateman Are the changes here OK with you?

[skateman]