Remove the unnecessary view_to_hash call from Foreman controller

[skateman]

I'm doing stuff in the GTL area ant this call seems unused and unnecessary. All these things go through the report_data call and it's always a separate request. @AparnaKarve could you please verify?

@miq-bot add_reviewer @AparnaKarve
@miq-bot add_label celanup, gaprindashvili/no, GTLs, configuration management

[miq-bot]

@skateman Cannot apply the following label because they are not recognized: celanup

[miq-bot]

Checked commit skateman@a648bac with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[AparnaKarve]

@skateman Apologies for the late reply here -- I was caught up with other things on Friday and could not reply here.

While reviewing this, I have noticed a GTL bug... which is somewhat related to view_to_hash...

In the screenshot below, the Unassigned Profiles Group which is in the tree, needs to appear in the list view too (this seems to be broken since Gaprindashvili) -

So just to be clear, as of now, view_to_hash does not seem to do anything - so it's probably OK to remove it.
Although after the report_data changes, the above bug needs to be addressed if possible.