Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to jQuery in application.js #4343

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

skateman
Copy link
Member

Analogous with #4329, this is needed if we want to load it properly from npm.

@miq-bot add_label bug
@miq-bot assign @himdel

@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

Checked commit skateman@20a7fa3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@himdel himdel added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 24, 2018
@himdel
Copy link
Contributor

himdel commented Jul 24, 2018

LGTM, adding gaprindashvili/no just because #4329 is.

Merging when green

@himdel himdel merged commit 9a6582d into ManageIQ:master Jul 24, 2018
@skateman skateman deleted the jquery-application branch July 24, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants