-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing gettext into angular controllers #4345
Add missing gettext into angular controllers #4345
Conversation
Checked commits mzazrivec/manageiq-ui-classic@bf386bc~...d1d21c3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in app/assets/javascripts/controllers/cloud_volume/cloud_volume_form_controller.js
(line 158):
vm.cloudVolumeModel.aws_iops = 'Not Applicable';
... @mzazrivec, is this one also missing gettext?
The extra line can be fixed in another PR if needed --> merging. |
Yep, created #4368 for that. Thanks! |
https://bugzilla.redhat.com/show_bug.cgi?id=1523326