Add ability to rename VMs #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstastna
force-pushed
the
Ability_to_rename_VMs
branch
29 times, most recently
from
814a182
to
0d98258
Compare
hstastna
force-pushed
the
Ability_to_rename_VMs
branch
from
1c2d8de
to
cc3482d
Compare
added 9 commits
August 13, 2018 22:01
Make the changes in vm_common and in some other places necessary for adding ability to rename VMs.
hstastna
force-pushed
the
Ability_to_rename_VMs
branch
from
cc3482d
to
bcc6514
Compare
agrare
approved these changes
Aug 13, 2018
There was a problem hiding this comment.
Tested with ManageIQ/manageiq#17853 applied and works as expected 👍
Add the changes to the new Rename module, to get a task_id and to save the new name of a VM while renaming it.
hstastna
force-pushed
the
Ability_to_rename_VMs
branch
from
592546e
to
e9f9e77
Compare
|
Checked commits hstastna/manageiq-ui-classic@13114ef~...e9f9e77 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
good to go, verified changes in UI. |
This was referenced Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFE: https://bugzilla.redhat.com/show_bug.cgi?id=1559184
What:
This VMware specific PR adds a new feature which allows users to rename VMs after provisioning has been completed (backend already done).
Why:
To simply rename VM without having to reprovision.
Backend PRs: (merged)
ManageIQ/manageiq#17853 (for
rename_queuemethod)ManageIQ/manageiq#17658
ManageIQ/manageiq-providers-vmware#291
ManageIQ/vmware_web_service#41
Done:
Renamemodule to Mixins for VM rename related methodsrenamefeature for a chosen VM in the list screenHow to test:
https://github.com/ManageIQ/manageiq-providers-vmware
https://github.com/ManageIQ/vmware_web_service
Then you need VMWare provider with its proper credentials and some VMs.
OR click on the VM to display its details page
Before:
After:
Rename selected item button:
Rename this VM button:
Renaming screen for a chosen VM (Compute > Infra > VMs):
Resetting changes of the name of a VM:
Canceling renaming of a VM:
Flash message after trying to rename a chosen VM from the list screen which is not supported (it's only for VMs of VMware provider!):
Renaming for other VMs - the button is visible but disabled (not VMware provider):
(you will see this after merging #4364, otherwise you will not see the button at all - if the feature will not be supported for a chosen VM)
Renaming of a VM from a nested list (provider's details page):
Rename of a VM task initiated successfully (from details page or list screen):