Use dialog-user component for more custom button object types #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
reviewed
Aug 1, 2018
| :cancel_endpoint => "/availability_zone" | ||
| ) | ||
| end | ||
| end |
There was a problem hiding this comment.
I see 15 it blocks doing very similar thing, just with different parameters. Could this be turned into a shared example perhaps? Or something else by using parameters?
There was a problem hiding this comment.
@mzazrivec Good call, easy fix with a shared example, will do that. 👍
eclarizio
force-pushed
the
BZ1597914
branch
2 times, most recently
from
665f9ef
to
8ac805a
Compare
skateman
reviewed
Aug 2, 2018
| context "when the object is a AvailabilityZone" do | ||
| let(:obj) { double(:class => ManageIQ::Providers::Vmware::InfraManager::AvailabilityZone, :id => 123) } | ||
|
|
||
| it_behaves_like "DialogLocalService#determine_dialog_locals_for_custom_button returning a hash", |
There was a problem hiding this comment.
Please use include_examples instead of it_behaves_like.
|
@eclarizio I made a note to work with QE once this PR is merged. |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1597914 This PR adds support with the dialog-user component for the following custom button object types: AvailabilityZone ContainerGroup ContainerImage ContainerProject ContainerTemplate ContainerVolume LoadBalancer NetworkRouter OrchestrationStack SecurityGroup Switch
|
Checked commits eclarizio/manageiq-ui-classic@65281ac~...d889ab8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/services/dialog_local_service_spec.rb
|
rvsia
pushed a commit
to rvsia/manageiq-ui-classic
that referenced
this pull request
Aug 14, 2018
Use dialog-user component for more custom button object types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3439
This PR adds support with the dialog-user component for the following custom button object types:
AvailabilityZoneContainerGroupContainerImageContainerProjectContainerTemplateContainerVolumeLoadBalancerNetworkRouterOrchestrationStackSecurityGroupSwitchI also refactored the case statement a bit, since a lot of these new objects were simple, so basically now unless something needs special handling, it will fall through to the
elsepart of the case statement and default to changing something likeAvailabilityZoneintoavailability_zonesfor the API collection name and"/availability_zone"for the UI cancel endpoint.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1597914
/cc @gmcculloug
@d-m-u Can you review, please?
@tinaafitz Do you think you can help set up something with QE so we can test all of these new object types with custom buttons? I was able to test a few of them locally but the others I don't have the data for and not sure how to set them up properly.
@miq-bot assign @h-kataria
@miq-bot add_label enhancement, automation/automate