Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding some required config to charts-mixin #4381

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Adding some required config to charts-mixin #4381

merged 1 commit into from
Jul 31, 2018

Conversation

felipedf
Copy link
Member

@felipedf felipedf commented Jul 30, 2018 •
edited
Loading

@miq-bot
Copy link
Member

miq-bot commented Jul 30, 2018

Checked commit felipedf@1ecccfd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@felipedf felipedf changed the title Adding some needed config to charts-mixin Adding some required config to charts-mixin Jul 30, 2018
@felipedf
Copy link
Member Author

@himdel

@himdel
Copy link
Contributor

himdel commented Jul 31, 2018

Related to #2499 , Cc @h-kataria

@felipedf
Copy link
Member Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Jul 31, 2018
@himdel
Copy link
Contributor

himdel commented Jul 31, 2018

LGTM, not seeing any breakage, and I am also no longer seeing this in cloud dashboards...

angular.self-f52e962…a54.js?body=1:14962 TypeError: Cannot read property 'position' of undefined
    at resentResourceController.$onInit (recent-resource.self…fcfbb3.js?body=1:22)
    at angular.self-f52e962…a54.js?body=1:10030
    at forEach (angular.self-f52e962…27a54.js?body=1:427)
    at nodeLinkFn (angular.self-f52e962…a54.js?body=1:10019)
    at angular.self-f52e962…a54.js?body=1:10411
    at processQueue (angular.self-f52e962…a54.js?body=1:17331)
    at angular.self-f52e962…a54.js?body=1:17379
    at Scope.$digest (angular.self-f52e962…a54.js?body=1:18516)
    at Scope.$apply (angular.self-f52e962…a54.js?body=1:18904)
    at done (angular.self-f52e962…a54.js?body=1:12776)

@himdel himdel merged commit 5e77d1a into ManageIQ:master Jul 31, 2018
@himdel himdel self-assigned this Jul 31, 2018
@himdel himdel added this to the Sprint 92 Ending Aug 13, 2018 milestone Jul 31, 2018
@felipedf felipedf deleted the config_chartmixin branch July 31, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himdel himdel

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felipedf @miq-bot @himdel