Fix unresponsive Save button while editing VM #4389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1610466
What:
Save button in editing screen of VM is not responsive: it remains enabled even if no change was made (of if there is nothing to save).
Why:
The problem was that if
changed
variable was set tofalse
, no update for Save button visibility was made. That's ok BUT what if Save button was enabled before and needs to be disabled now? This situation was not implemented in the code and it is simply fixed by removing conditionif changed
which is unnecessary and caused the bug.Steps to Reproduce:
for example enter something in Description form
=> Save button enables
=> Save button remains enabled!
Right after starting editing of a chosen VM:
Making some change of a VM:
Before: (after removing changes for VM)
After: