Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unresponsive Save button while editing VM #4389

Merged

Conversation

hstastna
Copy link

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1610466


What:
Save button in editing screen of VM is not responsive: it remains enabled even if no change was made (of if there is nothing to save).

Why:
The problem was that if changed variable was set to false, no update for Save button visibility was made. That's ok BUT what if Save button was enabled before and needs to be disabled now? This situation was not implemented in the code and it is simply fixed by removing condition if changed which is unnecessary and caused the bug.

Steps to Reproduce:

  1. Go to Compute > Infra > VMs (or to any page with VMs list screen)
  2. Click on some VM or check the checkbox
  3. Configuration > Edit Selected item/Edit this VM
  4. Make some change(s) in Basic Information or Parent VM Selection section,
    for example enter something in Description form
    => Save button enables
  5. Remove all of your changes
    => Save button remains enabled!

Right after starting editing of a chosen VM:
before_editing

Making some change of a VM:
editing

Before: (after removing changes for VM)
after_removing_changes

After:
after_removing_changes-after

@hstastna
Copy link
Author

@miq-bot add_label bug, gaprindashvili/yes

@hstastna
Copy link
Author

@h-kataria @mzazrivec This is a simple fix for Save button. Could you, please, check it? Thanks! 🎇

@miq-bot
Copy link
Member

miq-bot commented Jul 31, 2018

Checked commit hstastna@3efbfae with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@h-kataria h-kataria self-assigned this Jul 31, 2018
@h-kataria h-kataria added this to the Sprint 92 Ending Aug 13, 2018 milestone Jul 31, 2018
@h-kataria h-kataria merged commit 67fb56e into ManageIQ:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants