Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Dialog: Apply gettext on initial values #4395

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Aug 1, 2018

The fix consists of:

  • fix in dialog editor component (for cases when the dialog is being edited)
  • fix in dialog use component (for cases when the dialog is being run)
  • fix in dialog sample (for cases when the dialog is rendered as a preview in the right cell of explorer screen for)

Before:
dialog-before

After:
dialog-after

https://bugzilla.redhat.com/show_bug.cgi?id=1592573

@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2018

Checked commit mzazrivec@783d967 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec changed the title [WIP] Service Dialog: Apply gettext on initial values Service Dialog: Apply gettext on initial values Aug 2, 2018
@mzazrivec mzazrivec removed the wip label Aug 2, 2018
@skateman
Copy link
Member

skateman commented Aug 3, 2018

@miq-bot assign @martinpovolny

@martinpovolny martinpovolny merged commit 28f314a into ManageIQ:master Aug 6, 2018
@martinpovolny martinpovolny added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants