Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-raw-stdout: parse task id as string, not number #4397

Merged
merged 1 commit into from
Aug 2, 2018
Merged

ansible-raw-stdout: parse task id as string, not number #4397

merged 1 commit into from
Aug 2, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Aug 1, 2018

The "JS ids can't be numbers in region >9006" is here again, this is the same fix as #3243, but for ansible-raw-stdout.

https://bugzilla.redhat.com/show_bug.cgi?id=1610353

@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2018

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/843187f4fa185e9839f1bc6af7b4681b0f512864 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec self-assigned this Aug 2, 2018
@mzazrivec mzazrivec added this to the Sprint 92 Ending Aug 13, 2018 milestone Aug 2, 2018
@mzazrivec mzazrivec merged commit fa447ea into ManageIQ:master Aug 2, 2018
@himdel himdel deleted the raw-stdout-id branch August 2, 2018 11:15
@himdel
Copy link
Contributor Author

himdel commented Aug 3, 2018

issue: #1405

@JPrause
Copy link
Member

JPrause commented Oct 3, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Oct 3, 2018
simaishi pushed a commit that referenced this pull request Oct 5, 2018
ansible-raw-stdout: parse task id as string, not number
(cherry picked from commit fa447ea)

https://bugzilla.redhat.com/show_bug.cgi?id=1613333
@simaishi
Copy link
Contributor

simaishi commented Oct 5, 2018

Gaprindashvili backport details:

$ git log -1
commit a494b3d4c798dd6247323aeb02efcae9311348da
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Aug 2 10:51:30 2018 +0200

    Merge pull request #4397 from himdel/raw-stdout-id
    
    ansible-raw-stdout: parse task id as string, not number
    (cherry picked from commit fa447eada75226eb7f076f1ce3868b019b86a819)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1613333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants