Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webmks console button to instance operations button mixin #4481

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

skateman
Copy link
Member

The button_group('vm_access') defined in x_vm_cloud_center.rb overrides the same group created in the InstanceOperationsButtonGroupMixin that is being included just before. Therefore, the remote console button for OpenStack instances is missing. By moving the webmks console to the InstanceOperationsButtonGroupMixin and dropping the button_group the issue is fixed.

Before:
screenshot from 2018-08-16 12-03-52

After:
screenshot from 2018-08-16 12-01-06

@miq-bot add_label bug, toolbars
@miq-bot add_reviewer @mzazrivec

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1615796

@miq-bot
Copy link
Member

miq-bot commented Aug 16, 2018

Checked commit skateman@7482010 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@aufi
Copy link
Member

aufi commented Aug 16, 2018

Looks good 👍 thanks @skateman

@mzazrivec mzazrivec self-assigned this Aug 16, 2018
@mzazrivec mzazrivec added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 16, 2018
@mzazrivec mzazrivec merged commit bd9b343 into ManageIQ:master Aug 16, 2018
@skateman skateman deleted the restore-openstack-vnc branch August 16, 2018 13:21
@gildub
Copy link
Contributor

gildub commented Aug 27, 2018

This is the BZ tracker for Gaprindashvili:
https://bugzilla.redhat.com/show_bug.cgi?id=1622471

@gildub
Copy link
Contributor

gildub commented Aug 27, 2018

The back port won't work for Gaprindashvili because the line removed from app/helpers/application_helper/toolbar/x_vm_cloud_center.rb have to apply at a different part of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants