Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'Paste' button only if the copied and selected target class are the same #4575

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

romanblanco
Copy link
Member

Correction of #4513 (comment)

As @h-kataria mentioned, the buttons is supposed to be disabled, if the copied target class differs from the current target class.

This PR corrects the behaviour

Links

@romanblanco romanblanco changed the title Enable 'Paste' button only if the copied and selected target class are Enable 'Paste' button only if the copied and selected target class are the same Aug 31, 2018
@romanblanco
Copy link
Member Author

@miq-bot add_label automation/automate, bug, fine/yes, gaprindashvili/yes

@romanblanco romanblanco force-pushed the bz1426390 branch 3 times, most recently from 4cf64b4 to 4283211 Compare September 3, 2018 12:22
@miq-bot
Copy link
Member

miq-bot commented Sep 3, 2018

Checked commits romanblanco/manageiq-ui-classic@840e104~...15eaa01 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 3 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

spec/views/shared/buttons/_ab_form.html.haml_spec.rb

  • ❗ - Line 10, Col 32 - Layout/MultilineArrayBraceLayout - Closing array brace must be on the line after the last array element when opening brace is on a separate line from the first array element.
  • ❗ - Line 7, Col 7 - Layout/IndentArray - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

@mzazrivec mzazrivec self-assigned this Sep 4, 2018
@mzazrivec mzazrivec added this to the Sprint 94 Ending Sep 10, 2018 milestone Sep 4, 2018
@mzazrivec mzazrivec merged commit ba7e767 into ManageIQ:master Sep 4, 2018
@romanblanco romanblanco deleted the bz1426390 branch September 4, 2018 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants