-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error flash messages when creating tasks #4589
Merged
martinpovolny
merged 12 commits into
ManageIQ:master
from
mzazrivec:fix_error_flash_msgs_when_creating_tasks
Sep 5, 2018
Merged
Fix error flash messages when creating tasks #4589
martinpovolny
merged 12 commits into
ManageIQ:master
from
mzazrivec:fix_error_flash_msgs_when_creating_tasks
Sep 5, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the task creation failed, we cannot treat task_id as an integer.
Since task creation failed, we cannot treat task_id as an integer.
Since the task creation failed, we cannot treat task_id as integer.
Since task creation failed, we cannot treat task_id as integer.
Since task creation failed, we cannot treat task_id as integer.
Since task creation failed, we cannot treat task_id as integer.
Since task creation failed, we cannot treat task_id as integer.
Since task creation failed, we cannot treat task_id as integer.
Since task creation failed, we cannot treat task_id as integer.
Since task creation failed, we cannot treat task_id as integer.
Since task creation failed, we cannot treat task_id as integer.
mzazrivec
force-pushed
the
fix_error_flash_msgs_when_creating_tasks
branch
from
September 4, 2018 14:04
bb576bf
to
c7725ff
Compare
Checked commits mzazrivec/manageiq-ui-classic@3cb5909~...c7725ff with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Right. Make sense 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places in our code we use the following logic:
This is obviously incorrect: since task creation failed,
task_id
is not an integer and we cannot treat it as integer in the flash error message.@martinpovolny