-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bower to npm: manageiq-ui-components #4694
Conversation
This pull request is not mergeable. Please rebase and repush. |
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/5d835959e4ed3ee476c571112df6d8b23962f520~...94b60c483e32328762dfc743289d2080da957d02 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This pull request is not mergeable. Please rebase and repush. |
@miq-bot remove_label wip |
this is done properly in #4735 but travis won't pass otherwise with no bower deps
@@ -20,7 +20,7 @@ else | |||
|
|||
# fail the whole test suite if bower install failed | |||
[ $STATUS = 0 ] || exit 1 | |||
[ -d vendor/assets/bower/bower_components ] || exit 1 | |||
#[ -d vendor/assets/bower/bower_components ] || exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bower to npm: manageiq-ui-components (cherry picked from commit 5ed9e2f)
Hammer backport details:
|
Issue #3734
Depends on #4690
Moves ui-components to npm.