Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass normalized_state into textual summaries for consistency #4706

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Pass normalized_state into textual summaries for consistency #4706

merged 1 commit into from
Oct 1, 2018

Conversation

skateman
Copy link
Member

The normalized_state method should be used for full consistency with quadicons.

Before:
screen-shot-2018-09-25-at-3 05 25-pm

After:
screenshot from 2018-09-26 15-36-15

@miq-bot add_reviewer @epwinchell
@miq-bot add_label bug, gaprindashvili/no, hammer/yes

@miq-bot
Copy link
Member

miq-bot commented Sep 26, 2018

Checked commit skateman@3a3ac34 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

epwinchell
epwinchell approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@epwinchell epwinchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good.

@skateman
Copy link
Member Author

@miq-bot assign @martinpovolny

@mzazrivec mzazrivec assigned mzazrivec and unassigned martinpovolny Oct 1, 2018
@mzazrivec mzazrivec added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 1, 2018
@mzazrivec mzazrivec merged commit 42396f2 into ManageIQ:master Oct 1, 2018
simaishi pushed a commit that referenced this pull request Oct 1, 2018
@mzazrivec @simaishi
Merge pull request #4706 from skateman/normalized-textual-powerstate
0e7fb59 
Pass normalized_state into textual summaries for consistency

(cherry picked from commit 42396f2)
@simaishi
Copy link
Contributor

simaishi commented Oct 1, 2018

Hammer backport details:

$ git log -1
commit 0e7fb5912228ac773d74515c569da055fe88ac0d
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Oct 1 12:19:06 2018 +0200

    Merge pull request #4706 from skateman/normalized-textual-powerstate
    
    Pass normalized_state into textual summaries for consistency
    
    (cherry picked from commit 42396f211b299d5ba43d8614e2b3ec4673d57e45)

@skateman skateman deleted the normalized-textual-powerstate branch October 23, 2018 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epwinchell epwinchell epwinchell approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug hammer/backported textual summaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skateman @miq-bot @simaishi @epwinchell @martinpovolny @mzazrivec