-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show acknowledgement when saving replication settings #4714
Show acknowledgement when saving replication settings #4714
Conversation
…t of operation (success of error message) would not be shown as flash message and usr would need to to go to MyTask screen to see if operation succesfull or failed. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633653
\cc @gtanzillo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
add_flash(_("Error during replication configuration save: %{message}") % {:message => task.message }, :error) | ||
end | ||
MiqTask.generic_action_with_callback(task_opts, queue_opts) | ||
add_flash(_("Replication configuration save initiated. Check status of task '#{task_opts[:action]}' on MyTasks screen")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#{task_opts[:action]}
inside _()
will not work. You have to use _("один %{two} три") % {:two => два}
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mzazrivec for review and nice explanation :)
Checked commits yrudman/manageiq-ui-classic@0330e31~...c04af58 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
…ion-setup-queued Show acknowledgement when saving replication settings (cherry picked from commit 883df6d) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633653
Hammer backport details:
|
This PR is follow-up to #4628
Issue: When queuing saving replication settings there is no confirmation after user clicking on Save button and it is not clear if task queued or not.
After:
![screen shot 2018-09-27 at 3 50 48 pm](https://user-images.githubusercontent.com/6556758/46171023-5baba700-c26d-11e8-974f-77e4e7a6a7ab.png)
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633653
@miq-bot add-label bug, hammer/yes