Show acknowledgement when saving replication settings #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of operation (success of error message) would not be shown as flash message and usr would need to to go to MyTask screen to see if operation succesfull or failed. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633653
|
\cc @gtanzillo |
mzazrivec
reviewed
Oct 1, 2018
| add_flash(_("Error during replication configuration save: %{message}") % {:message => task.message }, :error) | ||
| end | ||
| MiqTask.generic_action_with_callback(task_opts, queue_opts) | ||
| add_flash(_("Replication configuration save initiated. Check status of task '#{task_opts[:action]}' on MyTasks screen")) |
There was a problem hiding this comment.
#{task_opts[:action]} inside _() will not work. You have to use _("один %{two} три") % {:two => два} here.
There was a problem hiding this comment.
Thank you @mzazrivec for review and nice explanation :)
|
Checked commits yrudman/manageiq-ui-classic@0330e31~...c04af58 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Oct 2, 2018
…ion-setup-queued Show acknowledgement when saving replication settings (cherry picked from commit 883df6d) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633653
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is follow-up to #4628
Issue: When queuing saving replication settings there is no confirmation after user clicking on Save button and it is not clear if task queued or not.
After:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633653
@miq-bot add-label bug, hammer/yes