Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrapping switch #4718

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Fix wrapping switch #4718

merged 1 commit into from
Oct 1, 2018

Conversation

epwinchell
Copy link
Contributor

This PR fixes a bug where the bootstrap switches wrapped on some screens.

Old
screen shot 2018-09-28 at 12 57 44 pm

New
screen shot 2018-09-28 at 12 54 22 pm

https://bugzilla.redhat.com/show_bug.cgi?id=1549076

@epwinchell
Copy link
Contributor Author

@miq-bot add_label bug, gaprindashvili/yes, hammer/yes

@miq-bot

This comment has been minimized.

Sign in to view
@epwinchell
Copy link
Contributor Author

@miq-bot add_label formatting/styling

@epwinchell
Copy link
Contributor Author

@miq-bot assign @h-kataria

@miq-bot
Copy link
Member

miq-bot commented Sep 28, 2018

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/56c82584ddcdfbe42776b6e4ebaef3a2fa84f296 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@epwinchell epwinchell closed this Sep 28, 2018
@epwinchell epwinchell reopened this Sep 28, 2018
@mzazrivec mzazrivec assigned mzazrivec and unassigned h-kataria Oct 1, 2018
@mzazrivec mzazrivec added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 1, 2018
@mzazrivec mzazrivec merged commit c9b4e11 into ManageIQ:master Oct 1, 2018
simaishi pushed a commit that referenced this pull request Oct 1, 2018
@mzazrivec @simaishi
Merge pull request #4718 from epwinchell/switch_fix
2606221 
Fix wrapping switch

(cherry picked from commit c9b4e11)

https://bugzilla.redhat.com/show_bug.cgi?id=1549076
@simaishi
Copy link
Contributor

simaishi commented Oct 1, 2018

Hammer backport details:

$ git log -1
commit 2606221853c8e542486b3c1b6d944465b18f359d
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Oct 1 12:13:44 2018 +0200

    Merge pull request #4718 from epwinchell/switch_fix
    
    Fix wrapping switch
    
    (cherry picked from commit c9b4e1192174c52d6a627beb17a34323c1e96d54)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1549076

@epwinchell epwinchell deleted the switch_fix branch March 20, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug formatting/styling hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@epwinchell @miq-bot @simaishi @h-kataria @mzazrivec