Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the overview background color #4748

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Fixing the overview background color #4748

merged 1 commit into from
Oct 10, 2018

Conversation

felipedf
Copy link
Member

@felipedf felipedf commented Oct 9, 2018 •
edited
Loading

The background color of the PhysicalInfra Overview page was a little off, this is a fix for that.

https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/views/layouts/_center_div_no_listnav.html.haml#L9
Here it adds the style for the background only if the @lastaction is show_dashboard

BEFORE
image

AFTER
image

@ZitaNemeckova
Copy link
Contributor

@felipedf Can you add before/after screenshots to your description, please? Makes review easier :)

@felipedf
Copy link
Member Author

felipedf commented Oct 9, 2018

@ZitaNemeckova Updated 😄

skateman
skateman approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@mzazrivec mzazrivec self-assigned this Oct 10, 2018
@mzazrivec mzazrivec added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 10, 2018
@mzazrivec mzazrivec merged commit 15d0aa2 into ManageIQ:master Oct 10, 2018
@felipedf felipedf deleted the overview_background_color branch October 10, 2018 12:05
simaishi pushed a commit that referenced this pull request Oct 11, 2018
@mzazrivec @simaishi
Merge pull request #4748 from felipedf/overview_background_color
0694144 
Fixing the overview background color

(cherry picked from commit 15d0aa2)
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 0694144d8f7f08e848e4a8d6d5969aca13b75010
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Oct 10 09:25:06 2018 +0200

    Merge pull request #4748 from felipedf/overview_background_color
    
    Fixing the overview background color
    
    (cherry picked from commit 15d0aa2fad2cb460eb2adf21217c3a8771300c38)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug compute/physical infrastructure hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felipedf @ZitaNemeckova @simaishi @skateman @mzazrivec