Fix adding a new Service Catalog Item for Vmware Catalog Item Type

[hstastna]

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1630385

What:
There was a problem while adding a new Service Catalog Item for Vmware Catalog Item Type: nothing happened in the UI, no change, Catalog Item was not saved; no error message; error in log occurred.

Steps to reproduce:

1. Go to Services > Catalogs > Catalog Items accordion
2. Configuration > Add a New Catalog Item
3. Choose Catalog Item Type: VMware
4. Fill in the Name, choose some Dialog (yes, you need to create some Dialog before these steps if there are no ones), no matter if you choose some Catalog or not
5. Click on Add button
   => error:

[1] pry(#<ManageIQ::Providers::Vmware::InfraManager::ProvisionWorkflow>)> 
[----] F, [2018-10-09T16:17:08.243588 #18459:2b22530a6b6c] FATAL -- : Error caught: [NoMethodError] undefined method `errors' for false:FalseClass
/home/hstastna/manageiq/manageiq-ui-classic/app/controllers/catalog_controller.rb:940:in `atomic_req_submit'
/home/hstastna/manageiq/manageiq-ui-classic/app/controllers/catalog_controller.rb:94:in `atomic_st_edit'
/home/hstastna/manageiq/manageiq-ui-classic/app/controllers/catalog_controller.rb:74:in `servicetemplate_edit'

Note:
You can check Display in Catalog checkbox, while creating a Catalog Item, but it does not matter. It does not have any influence (comparing to what the BZ says).

---

Before: (nothing happens in the ui, no flash message, error in log)

After: (another required info was not filled in so flash messages occur)

---

Note2: (see the commit 56e0291)
Since request can be boolean or an object, I added request && to the appropriate line.
See this:

[1] pry(#<CatalogController>)> request&.errors.present?
NoMethodError: undefined method `errors' for false:FalseClass
from (pry):4:in `atomic_req_submit'

vs.

[2] pry(#<CatalogController>)> 
[3] pry(#<CatalogController>)> request && request&.errors.present?
=> false

https://github.com/ManageIQ/manageiq/blob/master/app/models/miq_request_workflow.rb#L84 returns false

[hstastna]

@miq-bot add_label bug, hammer/yes, blocker

[hstastna]

@miq-bot remove_label wip

[h-kataria]

verified fix. Looks good

[simaishi]

Hammer backport details:

$ git log -1
commit 470132be8367ddc6f06bab87f49cc6612c0f368a
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Wed Oct 10 11:39:22 2018 -0400

    Merge pull request #4750 from hstastna/Service_Catalogs_Cannot_add_new_Service_Catalog_Item2
    
    Fix adding a new Service Catalog Item for Vmware Catalog Item Type
    
    (cherry picked from commit d34a138465b54f66efb97dd752313d95544e09a1)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1630385