Do not allow to embed a method into itself in automate

[skateman]

Thanks to the selectable attribute of the miq-tree-selector component, it is possible to prevent to select a specific embedded method(s) in the tree. I am building here a regular expression from all the homonymic methods so the same method in an other domain cannot be selected.

@miq-bot add_reviewer @pkomanek
@miq-bot add_reviewer @h-kataria
@miq-bot add_label bug, hammer/yes

https://bugzilla.redhat.com/show_bug.cgi?id=1633815

[miq-bot]

@skateman 'pkomanek' is an invalid reviewer, ignoring...

[mkanoor]

@skateman
A user can copy the methods into their own domain, so now we would have the same named methods in multiple domains and none of these methods can be embedded.

There is a method called
MiqAeMethod.get_homonymic_across_domains(@user, '/DOM1/A/B/C/CLASS1/method1')

Which gets a list of all the places where this method exists and we should prevent it from being embedded.

The UI currently uses this to display a list of methods and instances across domains

[mkanoor]

The screen shot in the BZ shows the domain overrides.
The back end already filters out duplicates at execution time, the UI should just prevent the user from selecting this at edit time.

[skateman]

@mkanoor yup, I realized this isn't the right way. Not sure if we could do this in the UI with a cheap solution 😕

[skateman]

@billfitzgerald0120 @mkanoor I updated it to use the method you suggested, but I still think these things should be also validated on the model side.

[miq-bot]

Checked commit skateman@fcbbc90 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[mzazrivec]

@mkanoor Are you OK with the current fix? Thanks.

[martinpovolny]

ping @mkanoor ?

[d-m-u]

@mkanoor @gmcculloug @tinaafitz can we please get eyes on this?

[tinaafitz]

@skateman Looks good.

[simaishi]

Hammer backport details:

$ git log -1
commit c35a21caf7d74bc29d2637fba6d6c648fa3e2a21
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Jan 21 16:35:37 2019 -0500

    Merge pull request #4753 from skateman/embedded-method-selectable
    
    Do not allow to embed a method into itself in automate
    
    (cherry picked from commit 617a341ed6c8bf0e1055dec565017493891d339f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1672691