Remove catching flash messages in report_data_controller.js #4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label gaprindashvili/no, hammer/yes, bug, gtls |
https://bugzilla.redhat.com/show_bug.cgi?id=1639213 * oneMessage.msg is actually undefined (it should be oneMessage.message), it probably never works
|
Checked commit rvsia@85cc039 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
rvsia
changed the title
|
I tried this PR and it fixes also my BZ https://bugzilla.redhat.com/show_bug.cgi?id=1611612. 👍 from my side |
romanblanco
approved these changes
Oct 22, 2018
|
Not seeing any indications of |
simaishi
pushed a commit
that referenced
this pull request
Oct 22, 2018
Remove catching flash messages in report_data_controller.js (cherry picked from commit 888aa60) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1639213
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1639213
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1611612
Steps to Reproduce:
or Compute -> Clouds -> Instances
or Lifecycle -> Provision Instances
Actual results:
Two success messages appear, one without text
Expected results:
One success message appears
Before / After
NOTES
The
oneMessage.msg( here , introduced by #1245 ) is undefined, so it's causing empty messages. It should beoneMessage.message, but then it's causing double messages.I don't know if
msgis used somewhere else, but I checked issues from #1273 (which should be fixed by this piece of code) after I had removed the function and they are fixed anyway. So I think the function actually doesn't work right now. Maybe there was another change which fixed all these thing. I don't know.@karelhala @himdel @skateman Pinging you, because you were involved in that PR.