Show only servers in current region in Diagnostics #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit ZitaNemeckova@0aa0421 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@lpichler Can you look at this one too, please? |
lpichler
reviewed
Oct 31, 2018
| @@ -420,7 +420,7 @@ def diagnostics_server_list | |||
| zone = Zone.find_by_id(x_node.split("-").last) | |||
| @view, @pages = get_view(MiqServer, :named_scope => [[:with_zone_id, zone.id]]) # Get the records (into a view) and the paginator | |||
| else | |||
| @view, @pages = get_view(MiqServer) # Get the records (into a view) and the paginator | |||
| @view, @pages = get_view(MiqServer, :named_scope => [[:in_region, MiqRegion.my_region.region]]) # Get the records (into a view) and the paginator | |||
There was a problem hiding this comment.
great! and I believe can also use :in_my_region instead :in_region👍
There was a problem hiding this comment.
Yeah that works too and looks better. Changed 👍
|
@lpichler Are you OK with the current changes? |
ZitaNemeckova
force-pushed
the
filter_servers
branch
from
0aa0421
to
3837814
Compare
ZitaNemeckova
force-pushed
the
filter_servers
branch
from
3837814
to
e1859ab
Compare
lpichler
approved these changes
Nov 1, 2018
simaishi
pushed a commit
that referenced
this pull request
Nov 2, 2018
Show only servers in current region in Diagnostics (cherry picked from commit b897cec)
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4719 .
Have two Regions each with one or more servers.
Configuration -> Diagnostics -> select Region -> select Servers tab -> see that number of servers in tree and in GTL isn't same
Before:
After:
@miq-bot add_label bug, hammer/no