Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow apostrophes in custom button names #4900

Conversation

mzazrivec
Copy link
Contributor

  1. create a custom button with a dialog, name it so that it contains an apostrophe in its name, such as: Button l'Muf
  2. click on the custom button (in the place where the custom button shows)

Without this fix, the following javascript error would show:

miq_debug.self-aedfe7fb00583f1da479517ffd299e68803b26c55f81d74f9d992127b311a1f9.js?body=1:29 SyntaxError: missing ) after argument list
    at eval (<anonymous>)
    at Function.globalEval (jquery.js:343)
    at domManip (jquery.js:5291)
    at jQuery.fn.init.append (jquery.js:5431)
    at jQuery.fn.init.<anonymous> (jquery.js:5525)
    at access (jquery.js:3614)
    at jQuery.fn.init.html (jquery.js:5492)
    at miq_explorer.self-6b27f1944493f686bd5c589f4f733a8d6a1d0aa627bbfd17545cde40c904044f.js?body=1:113
    at lodash.js:4925
    at baseForOwn (lodash.js:3010)

https://bugzilla.redhat.com/show_bug.cgi?id=1646905

@miq-bot
Copy link
Member

miq-bot commented Nov 9, 2018

Checked commit mzazrivec@d87b3b7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@martinpovolny martinpovolny self-assigned this Nov 12, 2018
@martinpovolny martinpovolny added this to the Sprint 99 Ending Nov 19, 2018 milestone Nov 12, 2018
@martinpovolny martinpovolny merged commit 7acb64d into ManageIQ:master Nov 12, 2018
simaishi pushed a commit that referenced this pull request Nov 12, 2018
…tton_names

Allow apostrophes in custom button names

(cherry picked from commit 7acb64d)

https://bugzilla.redhat.com/show_bug.cgi?id=1646905
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit cad0a1fc5d01bafc766b8101ca318c83b532c160
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Mon Nov 12 13:00:02 2018 +0100

    Merge pull request #4900 from mzazrivec/allow_apostrophe_in_custom_button_names
    
    Allow apostrophes in custom button names
    
    (cherry picked from commit 7acb64d4b3d472fc8c6bb0690f283374577ae3e5)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1646905

@mzazrivec mzazrivec deleted the allow_apostrophe_in_custom_button_names branch November 19, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants