Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Delete message to display the entity type - "Generic Object Class" #4930

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Nov 15, 2018

Fixed the Delete message to display "Generic Object Class"

Before -

screen shot 2018-11-15 at 12 27 01 pm

After -

screen shot 2018-11-15 at 12 22 03 pm

https://bugzilla.redhat.com/show_bug.cgi?id=1644658
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650137

@h-kataria
Copy link
Contributor

verified in UI

@miq-bot
Copy link
Member

miq-bot commented Nov 26, 2018

Checked commit AparnaKarve@955f8fa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@h-kataria h-kataria added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 26, 2018
@h-kataria h-kataria merged commit dd153fa into ManageIQ:master Nov 26, 2018
simaishi pushed a commit that referenced this pull request Nov 26, 2018
Fix Delete message to display the entity type - "Generic Object Class"

(cherry picked from commit dd153fa)

https://bugzilla.redhat.com/show_bug.cgi?id=1644658
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 606c108004850396a1ced6d86c4efe81b77a0476
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Mon Nov 26 15:29:34 2018 -0500

    Merge pull request #4930 from AparnaKarve/bz1644658_fix_go_delete_msg
    
    Fix Delete message to display the entity type - "Generic Object Class"
    
    (cherry picked from commit dd153fa4ed80c9e544c84765cef79b4538deac25)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1644658

@ZitaNemeckova
Copy link
Contributor

@AparnaKarve AparnaKarve deleted the bz1644658_fix_go_delete_msg branch November 27, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants