Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support operation clear on CloudObjectStoreContainer #498

Merged
merged 1 commit into from
Mar 20, 2017
Merged

Support operation clear on CloudObjectStoreContainer #498

merged 1 commit into from
Mar 20, 2017

Conversation

miha-plesko
Copy link
Contributor

@miha-plesko miha-plesko commented Feb 27, 2017 •
edited
Loading

To clear CloudObjectStoreContainer means to remove all CloudObjectStoreObjects from it. This option is available from three views:

  1. CloudObjectStoreContainer list
    capture

  2. CloudObjectStoreContainer details
    capture

  3. CloudObjectStoreContainer per-storage-manager list
    capture

Depends on:

@miha-plesko
Copy link
Contributor Author

@miq-bot add_label enhancement,wip

@miq-bot
Copy link
Member

miq-bot commented Mar 7, 2017

This pull request is not mergeable. Please rebase and repush.

@miha-plesko
Support operation clear on CloudObjectStoreContainer
524fe8c 
To `clear` Container means to remove all objects from it.

Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
@miha-plesko miha-plesko changed the title [WIP] Support operation "Empty CloudObjectStoreContainer" Support operation clear on CloudObjectStoreContainer Mar 20, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2017

Some comments on commit miha-plesko@524fe8c

spec/controllers/application_controller/ci_processing_spec.rb

  • ⚠️ - 340 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 416 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
  • ⚠️ - 485 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2017

Checked commit miha-plesko@524fe8c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 3 offenses detected

spec/controllers/application_controller/ci_processing_spec.rb

@miha-plesko
Copy link
Contributor Author

@h-kataria I'd kindly ask you to look at this change. It's been a while since opened and we managed to merge all its dependencies by now so I think it's perfect time to push it forward.

@miq-bot assign @h-kataria

miha-plesko
miha-plesko commented Mar 20, 2017
View reviewed changes
app/controllers/application_controller/ci_processing.rb
else
display_name = _(task.capitalize)
method = task = "#{klass.name.underscore.to_sym}_#{task}"
end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A change in this file is needed due to naming inconsistency in the backend:

  • for operation params[:pressed] == "cloud_object_store_container_delete" the supports? task name is ":delete" and method to be executed is "delete_cloud_object_store_container"
  • for operation params[:pressed] == "cloud_object_store_container_clear" the supports? task name is ":cloud_object_store_container_clear" and method to be executed is "cloud_object_store_container_clear".

I expect other operations to follow second convention therefore I made it default.

@h-kataria
Copy link
Contributor

codeclimate errors on this PR will be worked on during refactoring tasks.

@h-kataria
Copy link
Contributor

changes look good.

@h-kataria h-kataria added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 20, 2017
@h-kataria h-kataria merged commit 8583cc6 into ManageIQ:master Mar 20, 2017
@miha-plesko miha-plesko deleted the empty_aws_bucket branch January 7, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h-kataria h-kataria

Labels
enhancement storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miha-plesko @miq-bot @h-kataria