Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1652491: filter security group list based on provider #5013

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

sseago
Copy link
Contributor

@sseago sseago commented Nov 29, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1652491

For setting the remote security group for security group
rules, the dropdown included all security groups, including
those for other providers. This commit filters the list
to only show security groups for the current provider.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1652491

For setting the remote security group for security group
rules, the dropdown included *all* security groups, including
those for other providers. This commit filters the list
to only show security groups for the current provider.
@miq-bot
Copy link
Member

miq-bot commented Nov 29, 2018

Checked commit sseago@776cfb8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Dec 3, 2018
@mzazrivec mzazrivec added this to the Sprint 100 Ending Dec 3, 2018 milestone Dec 3, 2018
@mzazrivec mzazrivec merged commit 87179d5 into ManageIQ:master Dec 3, 2018
simaishi pushed a commit that referenced this pull request Dec 3, 2018
Bug 1652491: filter security group list based on provider

(cherry picked from commit 87179d5)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1652491
@simaishi
Copy link
Contributor

simaishi commented Dec 3, 2018

Hammer backport details:

$ git log -1
commit 9834660cf24f0daf18520b198559cbe26edc650c
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Dec 3 10:26:18 2018 +0100

    Merge pull request #5013 from sseago/security_group_edit
    
    Bug 1652491: filter security group list based on provider
    
    (cherry picked from commit 87179d58b5000cc56cfb93c774268f23fb1ea0f2)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1652491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants