Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing single_quad definitions for ansible-related entities #5051

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Dec 6, 2018

Before: imagine no quadicons

After:
screenshot from 2018-12-06 14-14-28
screenshot from 2018-12-06 14-22-11
screenshot from 2018-12-06 14-24-26
screenshot from 2018-12-06 14-29-17

@miq-bot add_reviewer @epwinchell
@miq-bot add_label GTLs, hammer/yes, bug

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656534

@miq-bot
Copy link
Member

miq-bot commented Dec 6, 2018

Checked commit skateman@b0dffc1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Contributor

@epwinchell epwinchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good.

@dclarizio dclarizio self-assigned this Dec 6, 2018
@dclarizio dclarizio merged commit a19b3d8 into ManageIQ:master Dec 6, 2018
@dclarizio dclarizio added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 6, 2018
@skateman skateman deleted the missing-ansible-quads branch December 6, 2018 19:05
simaishi pushed a commit that referenced this pull request Dec 10, 2018
Add missing single_quad definitions for ansible-related entities

(cherry picked from commit a19b3d8)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656534
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit fe62a736b9cbd8dcbdffa0236a8b981cf6630fc4
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Thu Dec 6 11:04:54 2018 -0800

    Merge pull request #5051 from skateman/missing-ansible-quads
    
    Add missing single_quad definitions for ansible-related entities
    
    (cherry picked from commit a19b3d84ad31cc1e368094c8e0b6cd7b63eebcfb)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants