Use the uib-tab parameter for switching tabs on the tasks screen #5054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit skateman@ed98945 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Dec 10, 2018
Use the uib-tab parameter for switching tabs on the tasks screen (cherry picked from commit 9e541dc) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1655749
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression caused by the angular-bootstrap prefixing, the new parameter includes the
uib-prefix, but the controller was looking for thetabparameter.Before:
After:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1655749
@miq-bot add_reviewer @epwinchell
@miq-bot add_reviewer @himdel
@miq-bot add_label bug, hammer/yes