-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing creating new Alert in Control > Explorer #5056
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@miq-bot add_label bug, blocker, hammer/yes |
hstastna
force-pushed
the
Alert_creation_fail_nil
branch
2 times, most recently
from
December 7, 2018 12:49
a813cd8
to
749539d
Compare
hstastna
changed the title
[WIP] Fix failing creating new Alert in Control > Explorer
Fix failing creating new Alert in Control > Explorer
Dec 7, 2018
@miq-bot remove_label wip |
Check successful adding Alert while no Send an E-mail option was chosen.
hstastna
force-pushed
the
Alert_creation_fail_nil
branch
from
December 7, 2018 12:53
749539d
to
37f4cf7
Compare
@skateman Could you, please, check the spec? 😏 Thanks! |
Checked commits hstastna/manageiq-ui-classic@d9906ea~...37f4cf7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@hstastna looks good |
simaishi
pushed a commit
that referenced
this pull request
Dec 10, 2018
Fix failing creating new Alert in Control > Explorer (cherry picked from commit 8615b74) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1654896
Hammer backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1654896
Related PR:
#4947
What:
This PR fixes failing creating a new Alert in Control > Explorer page.
Steps to reproduce:
check the Show on Timeline checkbox, in Timeline Event section instead of Send an E-mail, for example
=> error:
Notes:
Failing depends on which info is (not) filled in while creating a new alert - it does not happen always.
Mostly failing does not occur if all the info is filled in properly, including the emails.
Before: (not able to create a new Alert, nothing happens in the UI)
After:(creating a new Alert successful)