Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to display icon as image on Monitoring -> Alerts cards #5059

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Dec 6, 2018

Before:
screenshot from 2018-12-06 20-46-00
After:
screenshot from 2018-12-06 20-19-00

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656990

@miq-bot add_reviewer @epwinchell
@miq-bot add_label bug, gaprindashvili/yes, hammer/yes

@skateman
Copy link
Member Author

skateman commented Dec 6, 2018

@miq-bot assign @mzazrivec

@miq-bot
Copy link
Member

miq-bot commented Dec 6, 2018

Checked commit skateman@4376223 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec added this to the Sprint 101 Ending Dec 17, 2018 milestone Dec 7, 2018
@mzazrivec mzazrivec merged commit ae780eb into ManageIQ:master Dec 7, 2018
@skateman skateman deleted the alert-card-image branch December 7, 2018 07:57
simaishi pushed a commit that referenced this pull request Dec 10, 2018
Do not try to display icon as image on Monitoring -> Alerts cards

(cherry picked from commit ae780eb)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656990
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit f5e9261a19912c25c86aeaa5ae35b8392720b159
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Dec 7 08:49:04 2018 +0100

    Merge pull request #5059 from skateman/alert-card-image
    
    Do not try to display icon as image on Monitoring -> Alerts cards
    
    (cherry picked from commit ae780ebd508b791876c3e66a7dd82b08f4f5cb3d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656990

simaishi pushed a commit that referenced this pull request Dec 14, 2018
Do not try to display icon as image on Monitoring -> Alerts cards

(cherry picked from commit ae780eb)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1657400
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 752c2b3a6fba9f839c0fd009a62431bd8db4981d
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Dec 7 08:49:04 2018 +0100

    Merge pull request #5059 from skateman/alert-card-image
    
    Do not try to display icon as image on Monitoring -> Alerts cards
    
    (cherry picked from commit ae780ebd508b791876c3e66a7dd82b08f4f5cb3d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1657400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants