Fixed 'Catalog' should not be a required field #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
changed the title
|
Checked commits h-kataria/manageiq-ui-classic@affcd7b~...185a24d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
h-kataria
changed the title
|
Updated Dialog Options
|
|
👍 looks good |
|
Isn't the desired feature when |
|
@bzwei no Catalog field is not mandatory. If user doesn't select a Catalog, Catalog Item will end up in unassigned folder. |
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Mar 6, 2017
This was still causing catalog drop down to be a required field and not enabling "Add" button on screen. Catalog drop down was changed to be a not required field in ManageIQ#514
h-kataria
added a commit
to h-kataria/manageiq-ui-classic
that referenced
this pull request
Mar 6, 2017
This was still causing catalog drop down to be a required field and not enabling "Add" button on screen. Catalog drop down was changed to be a not required field in ManageIQ#514
TomasKohoutek
pushed a commit
to TomasKohoutek/manageiq-ui-classic
that referenced
this pull request
Apr 7, 2017
This was still causing catalog drop down to be a required field and not enabling "Add" button on screen. Catalog drop down was changed to be a not required field in ManageIQ#514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#@epwinchell can you help with formatting of Create New Dialog text-box.