Fix missing paging in provisioning template selection #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go to `/miq_request/pre_prov?template_klass=cloud` there is a GTL with a list of templates, but thanks to `@in_a_form = true` (and `center_div_no_listnav` checking both `layout_uses_paging? && !@in_a_form`), that means no paging toolbar. That was correct when this was not using the GTL component but no longer, removing.
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/60c5e9717ac6333dcd899f61080ae15c3b10fd78 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jan 14, 2019
Fix missing paging in provisioning template selection (cherry picked from commit 5f6a670) https://bugzilla.redhat.com/show_bug.cgi?id=1665908
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute -> clouds -> providers -> select cloud_provider(Openstack/Amazon) -> instances -> lifecycle -> provision instances
(or go to
/miq_request/pre_prov?template_klass=clouddirectly)there is a GTL with a list of templates,
but thanks to
@in_a_form = true(andcenter_div_no_listnavchecking bothlayout_uses_paging? && !@in_a_form),that means no paging toolbar.
That was correct when this was not using the GTL component but no longer, removing.
(The screen was converted to use GTL in #4509, adding hammer/yes.)
Cc @PanSpagetka
Cc @Pratik1Awchat
(A workaround for this is running
$('#paging_div').show(); miqInitMainContent()in the browser console on that screen.)BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1665908