Advanced Search Save: don't create unnecessary flash message

[mzazrivec]

1. Advanced search
2. Commit search expression
3. Hit Save button
4. Watch log/evm.log

Before:

ERROR -- : MIQ(vm_infra_controller-adv_search_button): Search Name is required

After: no unnecessary error log

https://bugzilla.redhat.com/show_bug.cgi?id=1670472

[h-kataria]

@mzazrivec not sure i understand the purpose of this check, this method is called when save/saveit buttons are pressed, don't we need to show flash message in both cases?

manageiq-ui-classic/app/controllers/application_controller/advanced_search.rb

Lines 245 to 247 in d6028b8

	case params[:button]
	when "save", "saveit"
	if adv_search_button_saveid

[mzazrivec]

IIRC, save button is that Save button, which takes you from expression editor to the filter save form. saveit does the actual filter save.

So in the first case, we don't render any flash message. The above code would just cause the flash message to show in app's log. We want to render flash only in the second case, hence the fix above. Although I'm not 100% sure this is the best fix.

[h-kataria]

@mzazrivec makes sense now, thx for explanation 👍

[miq-bot]

Checked commit mzazrivec@d6028b8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪