Don't allow adding another svc bundle into an existing bundle #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mzazrivec who can help review this PR. We need this for the hammer build. |
|
@mzazrivec can you also add spec test for this change, otherwise change looks good. |
mzazrivec
force-pushed
the
dont_show_another_bundle_when_editing_bundle
branch
from
436b774
to
60f6990
Compare
|
@h-kataria test added. |
|
Checked commits mzazrivec/manageiq-ui-classic@b4fbee4~...60f6990 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Feb 18, 2019
…_editing_bundle Don't allow adding another svc bundle into an existing bundle (cherry picked from commit 60b3dff) https://bugzilla.redhat.com/show_bug.cgi?id=1678368
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
https://bugzilla.redhat.com/show_bug.cgi?id=1671522