Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF download for job template summary #523

Merged

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Mar 1, 2017

Fixed the PDF download for a configured systems as well as for an Ansible Tower Job Template:

https://bugzilla.redhat.com/show_bug.cgi?id=1423380
https://bugzilla.redhat.com/show_bug.cgi?id=1427948

@lgalis lgalis changed the title Pdf download for job template summary [WIP]Pdf download for job template summary Mar 1, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Mar 1, 2017

@miq-bot add_label wip, ui, bug

@lgalis lgalis force-pushed the pdf_download_for_job_template_summary branch 2 times, most recently from 4be9639 to c96d8bf Compare March 1, 2017 14:59
@miq-bot
Copy link
Member

miq-bot commented Mar 2, 2017

This pull request is not mergeable. Please rebase and repush.

@lgalis lgalis force-pushed the pdf_download_for_job_template_summary branch from c96d8bf to 28dfdf0 Compare March 2, 2017 18:36
@chessbyte chessbyte changed the title [WIP]Pdf download for job template summary [WIP] PDF download for job template summary Mar 2, 2017
@dclarizio dclarizio removed the ui label Mar 13, 2017
@lgalis lgalis force-pushed the pdf_download_for_job_template_summary branch from 28dfdf0 to 2b3753d Compare April 10, 2017 15:27
@lgalis lgalis changed the title [WIP] PDF download for job template summary PDF download for job template summary Apr 10, 2017
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2017

Checked commit lgalis@2b3753d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. ⭐

@miq-bot miq-bot removed the wip label Apr 10, 2017
@lgalis
Copy link
Contributor Author

lgalis commented Apr 10, 2017

@dclarizio - please review

@dclarizio dclarizio self-assigned this Apr 10, 2017
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2017

@lgalis Cannot apply the following label because they are not recognized: euwe/no fine/yes

@lgalis
Copy link
Contributor Author

lgalis commented Apr 10, 2017

@miq-bot add_label fine/yes, euwe/no

@dclarizio dclarizio merged commit a02e86d into ManageIQ:master Apr 10, 2017
@dclarizio dclarizio added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 10, 2017
simaishi pushed a commit that referenced this pull request Apr 11, 2017
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit c40533d9e8151394661e5c6dd1d8d60b2c76fd5d
Author: Dan Clarizio <dclarizi@redhat.com>
Date:   Mon Apr 10 09:58:22 2017 -0700

    Merge pull request #523 from lgalis/pdf_download_for_job_template_summary
    
    PDF download for job template summary
    (cherry picked from commit a02e86da371a7d39a6a1b00871a35d374368b997)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1441303

@simaishi
Copy link
Contributor

simaishi commented Jun 6, 2017

Backported to Euwe via ManageIQ/manageiq#15304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants