Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription ID is required when adding, readOnly when editing (Azure) #5359

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Mar 20, 2019

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1519359

Description

Compute > Clouds > Providers > Edit selected (Azure) / Add a new Cloud Provider

Expected results
Subscription ID should be

  • required field when adding an Azure Provider
  • a read only field when edititng existing Azure provider.

Before
image
image

After
image
image

@miq-bot
Copy link
Member

miq-bot commented Mar 20, 2019

Checked commit rvsia@95df1ce with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@rvsia
Copy link
Contributor Author

rvsia commented Mar 20, 2019

@miq-bot add_label hammer/yes, compute/cloud, bug

@mzazrivec mzazrivec self-assigned this Mar 21, 2019
@mzazrivec mzazrivec added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 21, 2019
@mzazrivec mzazrivec merged commit 4166574 into ManageIQ:master Mar 21, 2019
@rvsia rvsia deleted the bz1519359 branch September 17, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants