Fixes segmentation_id and physical_network required (in Cloud Network form) #5364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649280 FLAT -> segmentation_id not needed GRE -> segmentation_id is GRE ID VLAN -> segmentation_id is VLAN ID VXLAN -> segmentation_id not needed Physical network: It isn't required for VXLAN and GRE But VLAN and Flat do require it. In which case the value is provided by a logical name (mapping to a real physical network)
rvsia
changed the title
|
@miq-bot add_label hammer/yes, networks, bug |
rvsia
changed the title
|
Checked commit rvsia@02eb283 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649280
Networks > Networks > Configuration > Add a new Cloud NetworkDescription
As you can see in the table, some fields should be required, but they are not.
FLAT -> segmentation_id not needed
GRE -> segmentation_id is GRE ID
VLAN -> segmentation_id is VLAN ID
VXLAN -> segmentation_id not needed
Physical network:
It isn't required for VXLAN and GRE
But VLAN and Flat do require it. In which case the value is provided by a logical name (mapping to a real physical network)
Before
After
