miqSetToolbarCount - fix setting toolbar counts #5403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miqSetButtons is not only called for toolbars, but also fake toolbars, so, we can't always update the toolbar count when nonzero. But for specific cases we can - so splitting the functionality into miqSetToolbarCount, which will always set the count for toolbars. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1694712
|
Cc @skateman :) |
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/b063791e41cd02b1d30d2cfc30e81108d0bf07f3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 22, 2019
miqSetToolbarCount - fix setting toolbar counts (cherry picked from commit adf2754) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1702066
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute > Infrastructure > VMs
pick a VM with a parent/child (
vm.add_parent(other_vm); vm.save!)click Genealogy in textual summary
check 2 checkboxes
the compare toolbar button should work now
miqSetButtons is not only called for toolbars, but also fake toolbars,
so, we can't always update the toolbar count when nonzero.
But for specific cases we can - so splitting the functionality into miqSetToolbarCount,
which will always set the count for toolbars.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1694712
Fixes #64