Make Add button respond properly on changes while adding Catalog Item #5472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
hstastna
force-pushed
the
Add_button_enabled_Service_Catalog_Item
branch
from
7774f13
to
c24ab09
Compare
hstastna
changed the title
hstastna
force-pushed
the
Add_button_enabled_Service_Catalog_Item
branch
from
c24ab09
to
6db1e07
Compare
hstastna
force-pushed
the
Add_button_enabled_Service_Catalog_Item
branch
2 times, most recently
from
85f984e
to
2ac5861
Compare
hstastna
force-pushed
the
Add_button_enabled_Service_Catalog_Item
branch
7 times, most recently
from
79c28cc
to
59a4b8a
Compare
hstastna
changed the title
hstastna
force-pushed
the
Add_button_enabled_Service_Catalog_Item
branch
from
59a4b8a
to
60ea017
Compare
hstastna
force-pushed
the
Add_button_enabled_Service_Catalog_Item
branch
5 times, most recently
from
6cfbded
to
ce1971c
Compare
hstastna
changed the title
hstastna
force-pushed
the
Add_button_enabled_Service_Catalog_Item
branch
3 times, most recently
from
4331525
to
42fbd1e
Compare
hstastna
force-pushed
the
Add_button_enabled_Service_Catalog_Item
branch
2 times, most recently
from
f1ad645
to
7f94d26
Compare
hstastna
changed the title
hstastna
force-pushed
the
Add_button_enabled_Service_Catalog_Item
branch
3 times, most recently
from
784ddce
to
5941db2
Compare
|
@miq-bot add_label ivanchuk/yes |
added 2 commits
July 29, 2019 17:26
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1728774 Also add new copy_params_if_present method to params helper
Add specs for setting initialized values for entry points, dialog id, @edit when saving Catalog Item or choosing Catalog Item type.
hstastna
force-pushed
the
Add_button_enabled_Service_Catalog_Item
branch
from
5941db2
to
d77e21c
Compare
|
Checked commits hstastna/manageiq-ui-classic@d3c3878~...d77e21c with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_reviewer @romanblanco |
|
verified fix, looks good. |
h-kataria
approved these changes
Jul 30, 2019
simaishi
pushed a commit
that referenced
this pull request
Jul 30, 2019
…alog_Item Make Add button respond properly on changes while adding Catalog Item (cherry picked from commit 9ecceb4) https://bugzilla.redhat.com/show_bug.cgi?id=1728774
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1728774
Issue:
#5469
What:
Add button is already (always) enabled while adding a new Service Catalog Item, even when there is nothing to add, because we haven't filled in anything. This behavior is not consistent with other screens. We want Add button to properly response on changes, as in other screens.
How:
When user fills in some form, the text for the appropriate form is stored in
@edit[:new]where the original values are usually set tonil. The same values are copied to@edit[:current]in the beginning. If the user deletes the text from the form, the variable is set to""which is different to the original value, so thechangedvariable stilll 'detects' the change even when there is no change according to the original value (nil). So I am adding new common methodcopy_params_if_presentwhich deals with""vsnilvalues.Note:
This PR fixes response of Add button on changes (bot adding and editing Catalog Item), except Long Description. This is more complicated and requires different fix (Also not sure how this should work - issue: #5853).
Before: (when first time in for adding new Catalog Item, Add button already enabled!)
After: (when first time in for adding new Catalog Item, Add button disabled, there is nothing to add)
