Fix error when clicking on created Catalog Item in the list #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug, hammer/yes |
himdel
reviewed
Apr 23, 2019
| @@ -1860,7 +1860,7 @@ def open_parent_nodes(record) | |||
| parents = [:id => template_to_node_name(record)] | |||
| else | |||
| # Check for parent nodes missing from vandt tree and return them if any | |||
| parent_rec = ServiceTemplateCatalog.find(record.service_template_catalog_id) | |||
| parent_rec = ServiceTemplateCatalog.find_by_id(record.service_template_catalog_id) # nil is a valid value | |||
There was a problem hiding this comment.
Ah, miq-bot is right here, this should be find_by(:id =>.
It will probably complain again, and not be right that time :).
hstastna
force-pushed
the
Error_when_clicking_created_Catalog_Item
branch
from
fe105f4
to
507ee89
Compare
|
Checked commit hstastna@507ee89 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Apr 30, 2019
…talog_Item Fix error when clicking on created Catalog Item in the list (cherry picked from commit 02f596a) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1704772
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1702343
What:
This simple PR fixes issue about displaying Catalog Item's info (also Catalog Bundle's), when clicking on the Catalog Item from the list. In our case,
nilis a valid value so we prefer usingfind_by_idinstead of usingfind.Steps to reproduce:
in All Service Catalog Items screen, to view its details
=> clicking on a newly created Catalog Item in the list throws an error, nothing happens in the UI, Catalog Item's summary screen is not displayed.
Note:
I need this BZ to be fixed for #5445,
otherwise it will not be possible to display Catalog Item info (with selected Tenants in the tree I am adding there) properly from the list.
Clicking on the Catalog Item from the list:
Before:
After Clicking on created Catalog Item, nothing happens:
After:
Displaying created Catalog Item's info:
Displaying Catalog Bundle's info: