Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu Simplification: Drop the Optimize section #5485

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

skateman
Copy link
Member

As Utilization went into the Cloud Intel and the remaining two items under Optimize will also go away, I am dropping the menu section completely. Sorry @GregP for the caused merge conflicts, we got these colliding RFEs, but it's just deletion, so probably easy to rebase.

Before:
Screenshot from 2019-04-24 16-46-07
After:
Screenshot from 2019-04-24 16-45-50

@miq-bot add_reviewer @epwinchell
@miq-bot add_label ux/review, hammer/no

https://bugzilla.redhat.com/show_bug.cgi?id=1678196

Copy link
Contributor

@epwinchell epwinchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks fine.

@martinpovolny
Copy link
Member

Travis failure is legit!

Copy link
Member

@martinpovolny martinpovolny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the specs.

@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2019

Checked commit skateman@21c8f86 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

spec/presenters/tree_builder_ops_rbac_features_spec.rb

@martinpovolny martinpovolny merged commit 5cfd2d3 into ManageIQ:master Apr 25, 2019
@martinpovolny martinpovolny self-assigned this Apr 25, 2019
@martinpovolny martinpovolny added this to the Sprint 110 Ending Apr 29, 2019 milestone Apr 25, 2019
@skateman skateman deleted the drop-optimize branch April 25, 2019 16:42
@skateman
Copy link
Member Author

@miq-bot add_label changelog/yes

@terezanovotna
Copy link

@miq-bot remove_label ux/review
@miq-bot add_label ux/approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants