Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use feature detection to determine whether AZ should be selectable #5522

Merged
merged 1 commit into from
May 30, 2019

Conversation

mansam
Copy link
Contributor

@mansam mansam commented May 2, 2019

https://bugzilla.redhat.com/show_bug.cgi?id=1549128

This PR is part of the implementation to allow choosing an availability zone when creating a new Openstack Cinder volume. It makes the existing AWS-specific AZ selection code generic, and allows it to be enabled by checking the supports_volume_availability_zones feature. Depends on the core PR which adds supports_volume_availability_zones.

@mansam mansam force-pushed the volume-availability-zones branch from 75adb12 to 427a2b5 Compare May 28, 2019 20:26
@miq-bot
Copy link
Member

miq-bot commented May 28, 2019

Checked commit mansam@427a2b5 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 2 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.8-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

spec/controllers/cloud_volume_controller_spec.rb

@mansam mansam changed the title [WIP] Use feature detection to determine whether AZ should be selectable Use feature detection to determine whether AZ should be selectable May 30, 2019
@miq-bot miq-bot removed the wip label May 30, 2019
@mansam
Copy link
Contributor Author

mansam commented May 30, 2019

This PR replaces #5155

@h-kataria h-kataria self-assigned this May 30, 2019
@h-kataria h-kataria added this to the Sprint 113 Ending Jun 10, 2019 milestone May 30, 2019
@h-kataria h-kataria merged commit 4acc2a3 into ManageIQ:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants