Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tenant relationship in Providers, Automate Domain and Services #5575

Conversation

hstastna
Copy link

@hstastna hstastna commented May 14, 2019

RFE:
https://bugzilla.redhat.com/show_bug.cgi?id=1678122

More:
https://docs.google.com/document/d/1rpgBQA_MAfqZY00dnbRLMiOzqhbrB60UdnvSgg7X--Y/edit

What:
This PR adds displaying Tenant name in Providers, Automate Domain and Services. Tenant name will be displayed with this PR in Summary View of cloud or infra provider, in Relationships table. Also a new column with the Tenant name will be displayed in the List view of a Provider, Automate Domain or a Service Catalog Item/Catalog Bundle (it will not be included in: Grid View, Tile View, Dashboard view).

How to test:

  • For providers:
    Compute -> Infrastructure/Clouds -> Provider
    and choose some provider if you want to check the Summary view
  • For Automate Domain:
    Automation -> Automate -> Explorer
  • For Services:
    _Services -> Catalogs -> Catalog Items -> choose some Catalog Item/Catalog Bundle

TODO:

Note:
Tenant names are displayed only for admin users.


After:
Cloud Provider Summary View:
cloud_prov_t
Infrastructure Provider Summary View:
infra_prov_t
Cloud Providers' List View:
cloud_list
Infra Providers' List View:
infra_list
Automate Domain:
ae_after
Service Catalog Item - Summary screen:
service_after
Service Catalog Bundle - Summary screen:
bundle_after

@miq-bot miq-bot added the wip label May 14, 2019
@hstastna
Copy link
Author

@miq-bot add_label changelog/yes

@hstastna hstastna force-pushed the Tenant_relationship_Providers_AutomateDomain_Services branch 15 times, most recently from 270ff0d to e4a2688 Compare May 21, 2019 15:30
@hstastna hstastna force-pushed the Tenant_relationship_Providers_AutomateDomain_Services branch 8 times, most recently from 4203c38 to 3d2c7a5 Compare May 23, 2019 08:34
@hstastna hstastna force-pushed the Tenant_relationship_Providers_AutomateDomain_Services branch from 3d2c7a5 to 2363090 Compare May 31, 2019 09:55
@hstastna
Copy link
Author

@miq-bot add_reviewer @himdel
@miq-bot add_reviewer @h-kataria

@miq-bot miq-bot requested review from himdel and h-kataria May 31, 2019 09:59
@hstastna hstastna force-pushed the Tenant_relationship_Providers_AutomateDomain_Services branch 3 times, most recently from 0507022 to 735e34c Compare June 6, 2019 09:24
@hstastna hstastna force-pushed the Tenant_relationship_Providers_AutomateDomain_Services branch from 735e34c to 132e9a2 Compare June 7, 2019 09:03
@hstastna hstastna force-pushed the Tenant_relationship_Providers_AutomateDomain_Services branch from 132e9a2 to 9f6db06 Compare June 10, 2019 09:14
@@ -30,13 +30,17 @@ cols:
- total_storages
- total_vms
- total_miq_templates
- tenant.name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field should be either in cols or under include, not both.

(so, just include, col_order and headers for this one)
(same in the other yaml)

@hstastna hstastna force-pushed the Tenant_relationship_Providers_AutomateDomain_Services branch 2 times, most recently from a761f39 to 244022d Compare June 12, 2019 08:37
@hstastna hstastna changed the title [WIP] Add Tenant relationship in Providers, Automate Domain and Services Add Tenant relationship in Providers, Automate Domain and Services Jun 12, 2019
@miq-bot miq-bot removed the wip label Jun 12, 2019
@hstastna hstastna force-pushed the Tenant_relationship_Providers_AutomateDomain_Services branch from 244022d to 3cd7de8 Compare June 14, 2019 12:35
@miq-bot
Copy link
Member

miq-bot commented Jun 14, 2019

Checked commits hstastna/manageiq-ui-classic@5d3dd81~...3cd7de8 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
9 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.8-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@martinpovolny martinpovolny self-assigned this Jun 14, 2019
@martinpovolny martinpovolny added this to the Sprint 114 Ending Jun 24, 2019 milestone Jun 14, 2019
@martinpovolny martinpovolny merged commit 7cb30c3 into ManageIQ:master Jun 14, 2019
@martinpovolny
Copy link
Member

The part that is "pending core" was moved to a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants