Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom logo capability to the ‘About’ modal #566

Merged
merged 1 commit into from
Mar 3, 2017
Merged

Add custom logo capability to the ‘About’ modal #566

merged 1 commit into from
Mar 3, 2017

Conversation

epwinchell
Copy link
Contributor

Currently, the 'About' modal displays only the standard product logo and background. This PR updates that screen when custom logos are selected under the "Custom Logos" tab in the Server Settings Area.

https://bugzilla.redhat.com/show_bug.cgi?id=1427163
https://www.pivotaltracker.com/n/projects/1613907/stories/141014527

'About' modal displaying custom logos:
screen shot 2017-03-03 at 9 49 01 am

Updated text on "Custom Logos" screen
screen shot 2017-03-03 at 10 04 14 am

@epwinchell
Copy link
Contributor Author

@miq-bot add_label enhancement, euwe/no

@epwinchell
Copy link
Contributor Author

@miq-bot assign @dclarizio

@miq-bot
Copy link
Member

miq-bot commented Mar 3, 2017

Checked commit https://github.com/epwinchell/manageiq-ui-classic/commit/bc1c19c9c87ac1351f3afa1943f130562c5df71b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. ⭐

@epwinchell
Copy link
Contributor Author

@miq-bot add_label settings

@dclarizio dclarizio merged commit 86bd34f into ManageIQ:master Mar 3, 2017
@dclarizio dclarizio added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 3, 2017
@epwinchell epwinchell deleted the about_modal_logos branch October 25, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants