Unify the HTML5 canvas-based remote consoles under a single endpoint

[skateman]

The remote console support is a little messed up, we have separate buttons for:

• VNC/SPICE
• WebMKS
• VMRC

The visibility and enablement of these buttons is even more complicated, especially for VMs running on VMware. The availability depends on versions and also on an individual setting on each VM which can now be determined by the backend only.

As there's no practical difference between VNC, SPICE and WebMKS consoles (except of the availability of assets), I am joining the three console types into a single HTML5 meta type while following the same analogy on the backend. The user asks for a HTML5-based console and the backend determines which console is the best suitable and provides it. The intention behind this is to have better console support both here and in the SUI.

If the WebMKS support is turned on for a VMware VM, it doesn't mean that the remote console will actually work. If the WebMKS assets aren't available on the appliance, the console won't work. Due to the costly operation of determining what console type is supported, we can't know the console protocol type before requesting it. Therefore, the only way to warn the user is AFTER the console window is opened. I created a hack inspired by this idea that displays a warning message in the console if the assets aren't available.

https://bugzilla.redhat.com/show_bug.cgi?id=1532720

[skateman]

@miq-bot add_reviewer @martinpovolny
@miq-bot add_reviewer @himdel
@miq-bot add_label hammer/no, consoles, enhancement, changelog/yes

[skateman]

@miq-bot add_label pending core
Depends on: ManageIQ/manageiq#18927 and ManageIQ/manageiq-providers-vmware#409

[martinpovolny]

spec/helpers/application_helper/buttons/vm_html5_console_spec.rb

  exclamation - Line 9, Col 31 - Style/MutableConstant - Freeze mutable objects assigned to constants.

this is cheap to fix

[martinpovolny]

Looks good.

[miq-bot]

Checked commits skateman/manageiq-ui-classic@e43e9c9~...de80659 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
11 files checked, 2 offenses detected

app/helpers/application_helper/toolbar/cloud/instance_operations_button_group_mixin.rb

• ❗ - Line 116, Col 64 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/x_vm_center.rb

• ❗ - Line 263, Col 62 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.