Allow returning back to the previous controller, after clicking on Back button and to cancel policy sim properly #5839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label hammer/yes, bug |
hstastna
force-pushed
the
Fix_cancel_policy_sim
branch
from
a00132d
to
e7ccc5d
Compare
hstastna
changed the title
hstastna
force-pushed
the
Fix_cancel_policy_sim
branch
from
e7ccc5d
to
3d488bc
Compare
skateman
reviewed
Jul 23, 2019
hstastna
force-pushed
the
Fix_cancel_policy_sim
branch
from
3d488bc
to
ab2a316
Compare
added 4 commits
July 25, 2019 10:45
…nges" This reverts commit ed58a5c.
…ore" This reverts commit 2e6644b.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1717495 Also display quadicon of template which did not show up in policy simulation page when running against VMs and Templates.
hstastna
force-pushed
the
Fix_cancel_policy_sim
branch
from
ab2a316
to
d4de8de
Compare
|
Checked commits hstastna/manageiq-ui-classic@331b320~...d4de8de with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label ivanchuk/yes |
simaishi
pushed a commit
that referenced
this pull request
Jul 25, 2019
Allow returning back to the previous controller, after clicking on Back button and to cancel policy sim properly (cherry picked from commit aa7b10b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1717495
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1717495
When clicking on quadion of a VM or Template while running policy simulation, the actual controller was changed to
VmOrTemplate. After clicking on Back button, it remained the same. This was causing unexpected behavior later in the next steps, many variables not set properly, not able to cancel policy sim properly... To prevent this controller's 'change' #5580 was created.The solution worked well except the case that user chose some items from the list which were both VMs AND Templates, for policy sim, in Compute > Infra > Virtual Machines > VMs & Templates accordion. The problem was missing quadicon(s) of Template in policy simulation.
So little bit different approach is good to implement: going 'back' to the previous controller after clicking on Back button (instead of the same controller all the time). So I specified the controller name for getting proper url for
onclickfor appropriate Back button. By usingmodel_for_vmmethod we get a proper model of the@record, and withcontroller_for_vmwe get a proper controller name.Before:
After:
