UI changes needed for embedded ansible models #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changes in this PR look good, have a question on ManageIQ/manageiq#14199 for @mzazrivec |
mzazrivec
force-pushed
the
fixes_for_embedded_ansible_models
branch
from
730c1f3
to
478c2b5
Compare
|
Checked commit mzazrivec@478c2b5 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/decorators/manageiq/providers/embedded_automation_manager/configuration_script_source_decorator.rb
|
h-kataria
approved these changes
Mar 6, 2017
|
@mzazrivec : merging, but please, fix the whitespace Rubocop issue next time you touch this area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contingent on ManageIQ/manageiq#14199