Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Embedded Ansible repository unsused attributes #5848

Merged

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jul 22, 2019

@h-kataria Please review

cc @NickLaMuro @carbonin

@miq-bot
Copy link
Member

miq-bot commented Jul 22, 2019

Checked commit Fryguy@dc9c266 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

spec/helpers/ansible_repository_helper/textual_summary_spec.rb

@h-kataria h-kataria added this to the Sprint 116 Ending Jul 22, 2019 milestone Jul 22, 2019
@h-kataria h-kataria merged commit 7d99455 into ManageIQ:master Jul 22, 2019
@Fryguy Fryguy deleted the remove_ansible_repository_unsused_attrs branch July 22, 2019 19:28
@NickLaMuro
Copy link
Member

@Fryguy or @h-kataria Please add the embedded ansible label to this so we can track it in a PR search like this one:

https://github.com/pulls?utf8=%E2%9C%93&q=is%3Apr+label%3A%22embedded+ansible%22+archived%3Afalse+

@Fryguy
Copy link
Member Author

Fryguy commented Jul 22, 2019

There is no embedded ansible label here, so I'll have to add one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants